Merge pull request #457 from Giphy/bottle-data-fix-3

Bottle data fix 3
Giphy · Nov 5, 2024 · 689cc9f · 689cc9f
2 parents 059f9ed + e73400e
commit 689cc9f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/two-shrimps-divide.md b/.changeset/two-shrimps-divide.md
@@ -0,0 +1,5 @@
+---
+'@giphy/react-components': minor
+---
+
+move bottle data outside of picture tag
diff --git a/packages/react-components/src/components/gif.tsx b/packages/react-components/src/components/gif.tsx
@@ -295,8 +295,8 @@ const Gif = ({
                     alt={getAltText(gif)}
                     onLoad={shouldShowMedia ? onImageLoad : () => {}}
                 />
-                {isAd && bottleData?.tags?.map((tag: string, index: number) => <BottleData src={tag} key={index} />)}
             </picture>
+            {isAd && bottleData?.tags?.map((tag: string, index: number) => <BottleData src={tag} key={index} />)}
             {Overlay && (
                 // only render the overlay on the client since it depends on shouldShowMedia
                 <RenderOnClient>