Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary pangolayout fix for Julia 0.7 compatibility #325

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Temporary pangolayout fix for Julia 0.7 compatibility #325

merged 2 commits into from
Nov 8, 2018

Conversation

dehann
Copy link
Contributor

@dehann dehann commented Nov 6, 2018

See discussion here: GiovineItalia/Gadfly.jl#1206

cc @bjarthur , @d9w

Thanks!

@vchuravy vchuravy mentioned this pull request Nov 6, 2018
@codecov-io
Copy link

codecov-io commented Nov 6, 2018

Codecov Report

Merging #325 into master will decrease coverage by 48.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #325       +/-   ##
===========================================
- Coverage   79.44%   31.28%   -48.17%     
===========================================
  Files          14       18        +4     
  Lines        1192     3027     +1835     
===========================================
  Hits          947      947               
- Misses        245     2080     +1835
Impacted Files Coverage Δ
src/pango.jl 0% <ø> (ø)
src/Compose.jl 10.12% <0%> (-89.88%) ⬇️
src/table.jl 9.52% <0%> (-84.6%) ⬇️
src/list.jl 19.23% <0%> (-80.77%) ⬇️
src/property.jl 20.25% <0%> (-79.75%) ⬇️
src/misc.jl 29.62% <0%> (-54.59%) ⬇️
src/form.jl 44.18% <0%> (-52.76%) ⬇️
src/measure.jl 24.76% <0%> (-51.71%) ⬇️
src/cairo_backends.jl 36.25% <0%> (-46.02%) ⬇️
src/container.jl 43.75% <0%> (-44.49%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb9b07...ce854e1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants