-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to People API #177
Conversation
Thank you @plainerman! I quickly tested this and it looks like it might work without changing any configuration (e.g. adding APIs via the cloud console). If that's the case then there is no need for any change in the documentation. |
Would be great if someone could just try to copy paste the code and run it and check if there are changes needed. For me, the easiest way to do this, was to change the GoogleContactsEventsNotifier/code.gs Line 85 in d8e3d85
|
You can use the |
for those like me that are not much pratice, can you please also write the instruction for replace the old code with this, and let it work ? |
@WmOne We are currently checking, but if everything goes well it should not be different than any of the updates which were released in the previous years: copying and pasting the code should take care of everything. Anyways, when the official release will be rolled out I'll make sure that update instructions are included as always. |
Hey @plainerman, I've just copied https://raw.githubusercontent.com/GioBonvi/GoogleContactsEventsNotifier/22eb90a5ed344a8ecda142cf601c8f804a6057c7/code.gs and got the following I'm pretty sure I'm doing something not the way you intended it...
I'm a bit confused. EDIT: Resolved, see the explanation in #176 (comment) |
It worked flawlessly for me, looking good 👍
|
Great, awesome! Then I will change the code to work without V8 so that no change is needed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing changes
@GioBonvi it seems that this branch is good to go. Is there anything to do before merging it? |
can we please have same kind of instruction on what we have to do to implement this changes ? |
The old Google Contacts API has been deprecated.
This PR implements the migration to the new people API.
This PR fixes #176