Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Amazon JS verification #238

Closed
wants to merge 28 commits into from
Closed

Fix Amazon JS verification #238

wants to merge 28 commits into from

Conversation

NatKarmios
Copy link
Contributor

@NatKarmios NatKarmios commented Apr 2, 2023

Originally part of #229, JS being broken (#113) was becoming quite the blocker, so this has its own PR now.

Resolves #237

@@ -8,157 +8,19 @@

(*
One header field consists of two bytes that contain the field length,
encoded as a big-endian 16-bit integer, followed by the field contents
encoded as a big-endian 16i-bit integer, followed by the field contents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

giltho
giltho previously approved these changes Apr 2, 2023
@giltho giltho dismissed their stale review April 2, 2023 23:05

Reviewed the wrong PR

@NatKarmios NatKarmios closed this Oct 15, 2023
@NatKarmios NatKarmios deleted the nat/amazon-js branch October 15, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Amazon JS
2 participants