service-name warn only once if there is an oldBehavior=true

[oriSomething]

Related to #431

Also when there was no oldBehavior at all since it's default to true

• Test locally

[coveralls]

Coverage decreased (-0.07%) to 99.927% when pulling ea79123 on service-name-fix into a6fa1a6 on master.

[EmmanuelDemey]

Any update about this PR ? and about my comment ?

[oriSomething]

Sorry, barely have the time, since need to fix the 100% coverage.
If i understood your comment, I've moved it to before the return of the Object for ESLint traversing

[EmmanuelDemey]

But do we need this didWarnForDeprecatedBehavior flag ?

[oriSomething]

It's only made for logging the warning only once, and to flood like described in the issue, since the context param might changed by different files

[oriSomething]

I thought again, If oldBehavior is undefined, Maybe we should use ESLint warning instead of console.log? It won't break parse, and UX for the programmer will be better

[coveralls]

Coverage remained the same at 100.0% when pulling d56afa6 on service-name-fix into a6fa1a6 on master.

[oriSomething]

@Gillespie59 This PR is ready, but maybe I should replace the console.warn with ESLint warning?

[EmmanuelDemey]

But I do not the syntax for ESLint warnings :s

[oriSomething]

@Gillespie59 Sorry, I didn't understand

[EmmanuelDemey]

With the complete sentence ... sorry
But I do not know the syntax for ESLint warnings :s. What do you meen by ESLint warning ?

[oriSomething]

Ah, I meant by reporting ESLing warning (as reporting error) like any ESLint errors.
Reporting about "deprecated syntax"

[mateatslc]

would be nice to see this move