Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout-service should fail on $window.setTimeout #434

Closed
swar30 opened this issue Jan 15, 2017 · 6 comments
Closed

timeout-service should fail on $window.setTimeout #434

swar30 opened this issue Jan 15, 2017 · 6 comments

Comments

@swar30
Copy link

swar30 commented Jan 15, 2017

Right now timeout-service rule warns on setTimeout and on window.setTimeout but it does not warn on $window.setTimeout which is an unfortunate option as well.

Planning to provide pull request with added support, please let me know if there are any objections

@swar30
Copy link
Author

swar30 commented Jan 15, 2017

@Gillespie59 now that this has been merged to development branch, when will it make it into a release ?
I'm in no hurry as currently planning to have direct dependency on github branch in my repo, but would like to setup reminder of when I can switch to official release.

@EmmanuelDemey
Copy link
Owner

I will publish the new version when this PR is finished : #432

@swar30
Copy link
Author

swar30 commented Feb 25, 2017 via email

@swar30
Copy link
Author

swar30 commented Mar 5, 2017

@Gillespie59 any input on this, can we push forward release of new version with #435 ?

@EmmanuelDemey
Copy link
Owner

1.6.2 publish

@swar30
Copy link
Author

swar30 commented Mar 6, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants