move cache TTLs to a struct #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
requested changes
Dec 20, 2021
There was a problem hiding this comment.
I think this solves half of the problem. There are two parts to it:
- We should only have one struct with all of the TTL information. You have done this here 🤗
- 2nd part is about associating those TTLs with the respective functions such as
cacheconfig.IsBlocksRootDirand so on.
But, I think that this is going in the wrong direction.
The 1st/2nd part is already kind of done but we are only doing it in CachingBucketConfig; the new groupcache Getter function reimplements the same matching, right? Perhaps CachingBucketConfig could accept a nil cache.Cache and expose those functions like findGetConfig and so on. Then we could use them inside the getter function. What do you think?
Signed-off-by: akanshat <[email protected]>
GiedriusS
reviewed
Dec 23, 2021
Signed-off-by: akanshat <[email protected]>
Signed-off-by: akanshat <[email protected]>
Signed-off-by: akanshat <[email protected]>
onprem
reviewed
Jan 4, 2022
Signed-off-by: akanshat <[email protected]>
GiedriusS
reviewed
Jan 5, 2022
GiedriusS
reviewed
Jan 5, 2022
GiedriusS
approved these changes
Jan 5, 2022
GiedriusS
reviewed
Jan 5, 2022
Signed-off-by: akanshat <[email protected]>
GiedriusS
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: akanshat [email protected]
Changes
Verification