This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
119 write fully featured mac +arp + ip example #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanG077
suggested changes
Jun 6, 2024
rowanG077
suggested changes
Jun 6, 2024
Akribes
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Very clear and detailed! Formatting seems to go wrong in a few places, I didn't comment on everything there. I have one or two comments about some details.
Finally, I'd write a slightly longer introduction and mention the circuit-notation plugin somewhere for those unfamiliar with it.
MatthijsMu
force-pushed
the
119-write-fully-featured-mac-+arp-+-ip-example
branch
3 times, most recently
from
ef533fe to
38d9f5d
Compare
MatthijsMu
force-pushed
the
119-write-fully-featured-mac-+arp-+-ip-example
branch
from
38d9f5d to
5efad47
Compare
|
Would like to ask for a second iteration of reviews |
Akribes
approved these changes
Jun 7, 2024
rowanG077
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to hear whether this would be complete (modulo formatting)