Add support for CVSS V4 #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add separate fields for CVSS V4 - place who want to use CVSS V3 can continue to do so and ignore the V4 fields. Add a CVSS V4 calculator, from Red Hat's code, but refactored to use local variables. The calculators are in separate dialogs, so users may hide whichever one they are not using. Places where a score is used (ex sorting or the finding list) will use either score, with a preference for v4 if both are specified.
ColonelThirtyTwo
force-pushed
the
cvssv4
branch
from
f0dbfeb to
3b1ca71
Compare
| @@ -223,7 +237,7 @@ class Finding(models.Model): | |||
| extra_fields = models.JSONField(default=dict) | |||
|
|
|||
| class Meta: | |||
| ordering = ["severity", "-cvss_score", "finding_type", "title"] | |||
| ordering = ["severity", Coalesce("cvss_v4_score", "cvss_score").desc(nulls_last=True), "finding_type", "title"] | |||
There was a problem hiding this comment.
Functions don't work in Django pre-4.1 due to a bug, and indeed this breaks the findings list page.
|
Going with #509 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate fields for CVSS V4 - place who want to use CVSS V3 can continue to do so and ignore the V4 fields.
Add a CVSS V4 calculator, from Red Hat's code, but refactored to use local variables. The calculators are in separate dialogs, so users may hide whichever one they are not using.
Places where a score is used (ex sorting or the finding list) will use either score, with a preference for v4 if both are specified.
NOTE: I haven't tested the Hasura settings yet.
Alternate design: Could use the existing cvss_score/vector fields instead - show only one calculator based on the CVSS vector prefix or if the user selects the other one.