Update effects mappings #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!start-test-server |
|
Preparing and starting test server as requested by @AJ-Ferguson at 2020-07-30 23:18:10 UTC Downloading Geyser Standalone... Finished download, setting up docker container... Built docker container. Connect via 51.210.124.95:32798 ( |
Camotoy
approved these changes
Jul 31, 2020
The bedrock client plays an additional sound when using CAULDRON_EXPLODE. The java client does not play any sound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on GeyserMC/mappings#29
The effect mapper was refactored so mapping errors would be caught at startup and prevent constant errors.
Almost all effects should be mapped. Testing wanted.