Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone-remote-port option #798

Closed
wants to merge 5 commits into from
Closed

Conversation

blackalegator
Copy link
Contributor

Added a clone-remote-port option which makes the bedrock's port the same as the java's port if geyser is running as a plugin

Copy link
Member

@Camotoy Camotoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a check for this on Sponge's end too, just for consistency.

connector/src/main/resources/config.yml Outdated Show resolved Hide resolved
Updated config.yml to include a better description of the clone-remote-port option
An incorrect port was being edited before (remote instead of bedrock)
@blackalegator
Copy link
Contributor Author

I would also add a check for this on Sponge's end too, just for consistency.

Done

@Camotoy
Copy link
Member

Camotoy commented Jul 8, 2020

Please update this PR to support 1.16.

@Redned235
Copy link
Member

Looks like you have a merge conflict that needs to be resolved. Once that is taken care of, I can merge this 🙂

@Camotoy
Copy link
Member

Camotoy commented Jul 13, 2020

Superseded by #944.

@Camotoy Camotoy closed this Jul 13, 2020
@Redned235
Copy link
Member

Reopening since #944 does not include this commit history. Closed before realizing this was the case; sorry for the confusion!

@Redned235
Copy link
Member

Due to the lack of response from OP, this has been superseded by #1061. Commit history from this PR has been kept however. Regardless, thanks for the contribution!

@Redned235 Redned235 closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants