Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change versioning to match supported Bedrock version; add versioning command #730

Merged
merged 8 commits into from
Jul 6, 2020
Merged

Change versioning to match supported Bedrock version; add versioning command #730

merged 8 commits into from
Jul 6, 2020

Conversation

Camotoy
Copy link
Member

@Camotoy Camotoy commented Jun 3, 2020

Line up Geyser's versioning to match with the highest/currently supported Bedrock version for future tracking of older Geyser versions.

Open to discussion.

@Camotoy
Change versioning to match supported Bedrock version
8675a60 
Line up Geyser's versioning to match with the highest/currently supported Bedrock version for future tracking of older Geyser versions.
@ghost
Copy link

ghost commented Jun 3, 2020

I think you also should add information about the type of Geyser e.g. Standalone/Bukkit/Bungee/etc. This will be helpful for creating bug reports.

@rtm516 rtm516 added PR: Feature When a PR implements a new feature Work in Progress The issue is currently being worked on. labels Jun 3, 2020
@rtm516
Copy link
Member

rtm516 commented Jun 3, 2020

I think a /geyser version command could be added to this in the same style paper does it, also checking for updates. (I may add this)
Also I think the -SNAPSHOT should just be removed from the version.
And could it be possible to inherit the version from the core pom.xml so we only have to change the version in 1 place?

@bundabrg
Copy link
Collaborator

bundabrg commented Jun 3, 2020

Check my GitHub actions here: https://github.com/bundabrg/PortalNetwork/blob/master/.github/workflows/build.yml

I have the .pom set with a snapshot 1 medium version up which is uploaded to maven when pushed to master.

If I tag a build then the version is set to the tag version and sent to maven, release and spigot with that tagged version set in all the files plus a pretty log of every commit since the last tag is added where appropriate.

It means I never have to have a version bump commit except when I need to change the medium or major version and just use a GitHub tag each time I want to release a version and don't have to edit a bunch of files to do so.

@Camotoy Camotoy changed the title Change versioning to match supported Bedrock version Change versioning to match supported Bedrock version; add versioning command Jun 4, 2020
@Camotoy
Copy link
Member Author

Camotoy commented Jun 5, 2020

I believe -SNAPSHOT is kept for when a software is still under development, so I would keep that. I'm not partial to that, however.

@Redned235
Copy link
Member

I believe -SNAPSHOT is kept for when a software is still under development, so I would keep that. I'm not partial to that, however.

I don't think SNAPSHOT at this point is necessary anymore. Geyser is in a state where people are already using it on production environments, and looking at statistics its used by nearly 1000 people/servers. The main thing left right now is the movement, which is already in the process of being worked on.

@Camotoy
Copy link
Member Author

Camotoy commented Jun 6, 2020

👍

@Camotoy Camotoy added PR: On hold When a PR is on hold like if it requires a dependency to be updated first Waiting For Minecraft Update When a PR or issue likely won't be resolved before the next Minecraft update. and removed Work in Progress The issue is currently being worked on. labels Jun 15, 2020
@Redned235
Copy link
Member

Update: this pull request will be merged once 1.16 releases and Geyser is functioning/stable on that version.

@basaigh
Copy link
Member

basaigh commented Jun 25, 2020

Should this not be updated to 1.0.0-1.16.0, before it is merged?

@Camotoy Camotoy removed PR: On hold When a PR is on hold like if it requires a dependency to be updated first Waiting For Minecraft Update When a PR or issue likely won't be resolved before the next Minecraft update. labels Jul 6, 2020
@Camotoy Camotoy changed the base branch from master to feature/1.16 July 6, 2020 00:45
@Camotoy Camotoy merged commit afcf1e3 into GeyserMC:feature/1.16 Jul 6, 2020
Redned235 added a commit that referenced this pull request Jul 8, 2020
@Camotoy @rtm516
@williamjohnstone @AJ-Ferguson @basaigh @toinouH @Tim203 @Redned235 @dependabot @theminecoder @james090500
Merge 1.16 into master (#909)
4a425df 
* Rename Geyser-Bukkit to Geyser-Spigot

Despite the Bukkit suffix being correct in terms of the API, the name causes some people to download CraftBukkit instead of Spigot or Paper. All internal references to Bukkit have been renamed to Spigot.

* Rename internal ping passthrough variable

* Include PlatformType.java

* Update workflow

* (Incomplete) Update MCProtocolLib

* Update Message system

* Finish block state changes

* Don't forget about Bukkit

* Fix json data in chat

* Update mappings repository

* Update ViaVersion integration

* Begin updating Geyser. Requires manual MCProtocolLib compile

* According to all known laws of aviation, bees exist

* Remove ServerSpawnWeatherEntityPacket

* Bedrock 1.16 updating part 1

* Bedrock 1.16 updating part 2 (Doesn't work)

* Update for 1.16

* Relocate Reflections Dependency (#802)

* Update for 1.16.1

* Uncomment JavaDeclareCommandsTranslator and update

* Update Bedrock resources dumped by @bundabrg

* Update some entity properties based on wiki.vg

* Update ViaVersion dependency

* Update mappings repository

* Bump block state version

* Bump action versions (#810)

* Fix dimension switching; add static references to new Java dimensions

* Update mappings repository

* Add translator for PacketViolationWarningPacket

* Update PotionMixData

* Update JavaEntityEquipmentTranslator for Java 1.16

* Add new 1.16 entities

* Fix zombified piglins

* Remove try/catch from BlockTranslator and ItemTranslator

* Add closest color mapping for RGB chat colors

* Quick inventory fixes. WIP

Temporary. The inventory system will be rewritten very soon.

* Update Mappings (#816)

* Relocate Reflections Dependency

* Update some mappings

* Fix en_us locale downloading (#809)

Fixes occasional inventories not working because of being unable to read the locale.

* Fix creative items

* Add dump command (#808)

* Add dump command
Adds a command to collect and dump infomation about the Geyser install and bootstrap and submit it to a dumps site.

* Finalize URL; misc. fixes; add 'architecture' param

Co-authored-by: DoctorMacc <[email protected]>

* Update README.md (#811)

Versions of Java and Bedrock Edition supported updated

* Updated the mappings and fixed building

* Move common stuff used only by connector and bootstrap to connector

* Fix creative item list

* Fix first item of creative inventory not showing

* Non-working smithing table inventory support

* Update mappings submodule

Fixes shulker boxes

* Fix chat formatting and team colors

* Update to the latest MCProtocolLib commit

* Replace Bukkit with Spigot (#831)

* Return if sound is null and update mappings

* Fix some recipes with multiple ingredient options

* Fix disconnect message formatting

* Anvil fixes

* Fill in renamed villager trading values (villager trading UI now opens)

* Clean chat code and fix skins

* Fix baby states and collisions of 1.16 mobs

* Update entity metadata

* Drop long array nbt tag when translating to bedrock

* Update dependencies ('item marked as non-null' error is fixed')

* Fix blocks not updating

* Return to using Protocol develop branch

* Add Loadstone Compass tracking

* Handle int tag for enchantment level

* Fix stored enchantments accidentally being dropped

* Strider mounting fixes; update mappings

This commit refactors health visual logic to make it a global system for each living entity.

* Fix Zombified Piglin fire flicker

* Fix Strider shaking

* Update Bedrock Version (#868)

* Update Bedrock Version

* Update README.md

* Fix respawning and death not being registered on the client

* Add support for 3D biomes; fix Nether biome display

* Clean up formatting

* Update mappings to fix fences and plant stems

* Fix respawn bugs - hopefully for good

Thanks to @bundabrg for spotting this one.

* Set strider entity offset properly if not a player entity

* Add GUI to standalone

* Bump log4j-core from 2.13.1 to 2.13.2 in /bootstrap/standalone (#886)

Bumps log4j-core from 2.13.1 to 2.13.2.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix bug when dropping items from an open inventory

* Fix Strider cold state when riding and removing of the RIDING flag when a parent is killed

* Add comment and check for null when removing passengers

* Update mappings submodule

* Fix memory leak in legacy ping passthrough (Fixes #674, #813)

* Fix flower pots and item frames

* Fix ram graph causing memory leak and add cleanup of options menu on reload

* Update to Cloudburst NBT 2.0

* Update mappings submodule

* Send a dimension change upon join game packet now sent by bungeecord on 1.16

* Add Translation support (#504)

Adds full multi-language support to any Bedrock-supported language.

Co-authored-by: DoctorMacc <[email protected]>

* Fix player table throwing errors on interaction

* Don't cause a recursion error if Geyser can't find the locale

* Change versioning to match supported Bedrock version; add versioning command (#730)

* Change versioning to match supported Bedrock version

Line up Geyser's versioning to match with the highest/currently supported Bedrock version for future tracking of older Geyser versions.

* Add version command

* Fix DEV check for version command

* Remove SNAPSHOT

* Update languages submodule

Co-authored-by: rtm516 <[email protected]>

* Fix ping passthrough throwing errors on unknown properties (Fixes #903)

* Fix version checking and add failed language string

* Fix scoreboards bleeding into other servers (#902)

* Update MinecraftCapes endpoints (#907)

Updates the mccapes endpoints with the new domain.

* Fix fallback locale not loading

* Move back to using the main repository for MCProtocolLib

* JavaUpdateTileEntityTranslator improvements

- Remove the use of deprecated functions
- Check for empty NBT (fixes errors on CubeCraft)

* Fix RGB colors on signs causing chunk issues, fix items names not being displayed correctly

* Fix maps with negative IDs causing out of bounds errors

* Add the adventure-api maven repo

* Fix bug with maps

* Convert map of players to list (may address #833)

* Block-related updates

- Fix block breaking animation
- Fix block breaking particles
- Don't initialize Geyser's chunk cache if using Spigot

* Revert all 1.14.60-specific changes

* Don't use 1.16 branch of mappings

* Fix inabilty to place items into brewing stand

* Don't process the display tag if it's empty

* Fix banner block patterns

* Fix map_uuid nbt type

* Fix exact color matches not being formatted correctly (Fixes #912)

* Fix Piglin bartering animation (Fixes #863)

* Move to dynamic item ID mapping in ItemRegistry

* Save ItemEntry classes for items

* Add magma cube jumping visual

* Update MCProtocolLib to fix #836

* Update languages submodule

* Clean up some TODOs

* Add emote support for Bedrock-to-Bedrock players

* Remove debug string

Co-authored-by: rtm516 <[email protected]>
Co-authored-by: endevrr <[email protected]>
Co-authored-by: AJ Ferguson <[email protected]>
Co-authored-by: D3ATHBRINGER13 <[email protected]>
Co-authored-by: rtm516 <[email protected]>
Co-authored-by: toinouH <[email protected]>
Co-authored-by: Tim203 <[email protected]>
Co-authored-by: DoctorMacc <[email protected]>
Co-authored-by: RednedEpic <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: theminecoder <[email protected]>
Co-authored-by: James Harrison <[email protected]>
@Camotoy Camotoy deleted the version-change branch July 23, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Feature When a PR implements a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Camotoy @rtm516 @bundabrg @Redned235 @basaigh