Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for instance of TranslationMessage #722

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

Camotoy
Copy link
Member

@Camotoy Camotoy commented Jun 2, 2020

Checks for class of custom name ID in case it's translation message.

Untested.

Checks for class of custom name ID in case it's translation message.
@rtm516 rtm516 added PR: Bugfix When a PR contains a bugfix PR: Needs Testing When a PR needs testing but is currently not under review labels Jun 2, 2020
@bundabrg
Copy link
Collaborator

bundabrg commented Jun 2, 2020

Closes #715
Closes #557
Closes #686

Copy link
Member

@rtm516 rtm516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this has been tested it will be ready for merge

@bundabrg
Copy link
Collaborator

bundabrg commented Jun 2, 2020

I've uploaded a build for @OverBrave so will let you know if it works.

@bundabrg
Copy link
Collaborator

bundabrg commented Jun 2, 2020

This has been confirmed to work.

@Camotoy Camotoy merged commit 18891a2 into GeyserMC:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bugfix When a PR contains a bugfix PR: Needs Testing When a PR needs testing but is currently not under review
Projects
None yet
3 participants