Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't manually grab MCProtocolLib's dependencies #720

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

AJ-Ferguson
Copy link
Member

@AJ-Ferguson AJ-Ferguson commented Jun 2, 2020

Seems to increase jar size by 2MB because netty-all is not excluded anymore.
Re-adding the exclusion will cause an exception when connecting to the java server:

Fixed by 1dafb77

Exception in thread "Thread-1" java.lang.NoClassDefFoundError: io/netty/handler/codec/dns/DnsQuestion
        at com.github.steveice10.packetlib.tcp.TcpSessionFactory.createClientSession(TcpSessionFactory.java:25)
        at com.github.steveice10.packetlib.Client.<init>(Client.java:18)
        at org.geysermc.connector.network.session.GeyserSession.lambda$authenticate$0(GeyserSession.java:279)
        at java.lang.Thread.run(Thread.java:748)

@AJ-Ferguson AJ-Ferguson marked this pull request as draft June 2, 2020 00:40
@Camotoy
Copy link
Member

Camotoy commented Jun 2, 2020

Linux still causes an error - it's likely not our fault, therefore marking this as draft for the time being.

@AJ-Ferguson AJ-Ferguson marked this pull request as ready for review June 2, 2020 02:06
@Camotoy Camotoy merged commit 05024dd into GeyserMC:master Jun 2, 2020
@AJ-Ferguson AJ-Ferguson deleted the mcprotocollib-dep branch July 26, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants