Implement workaround for out of order StartGame packet #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the Bukkit suffix being correct in terms of the API, the name causes some people to download CraftBukkit instead of Spigot or Paper. All internal references to Bukkit have been renamed to Spigot.
Randomly the StartGame packet will end up sent after the packets that are supposed come after it. This workaround will force a 500ms delay after the packet to ensure it has the best chance of coming first.
Camotoy
requested changes
Jun 1, 2020
connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java
Show resolved
Hide resolved
Camotoy
approved these changes
Jun 2, 2020
|
How does vanilla Bedrock handle it? |
|
The bug in the Protocol library should be fixed instead |
|
The proper fix should be done in the Protocol library as other packets can and will be out of order throughout a session. However it may be a useful workaround until that takes place and can always be reverted later though by having the workaround in place there is then less pressure to fix the real issue. |
…eyser into DoctorMacc-mcprotocollibupdate
Temporary. The inventory system will be rewritten very soon.
* Relocate Reflections Dependency * Update some mappings
Fixes occasional inventories not working because of being unable to read the locale.
* Add dump command Adds a command to collect and dump infomation about the Geyser install and bootstrap and submit it to a dumps site. * Finalize URL; misc. fixes; add 'architecture' param Co-authored-by: DoctorMacc <[email protected]>
Versions of Java and Bedrock Edition supported updated
Fixes shulker boxes
# Conflicts: # connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java
bundabrg
added a commit
to bundabrg/Protocol
that referenced
this pull request
Jul 1, 2020
I think also fixes ProxyPass connection issues. Closes GeyserMC/Geyser#714
|
I'm pretty sure this is now resolved upstream |
|
I've had no issues with not being able to connect on the first try, so I agree. |
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomly the StartGame packet will end up sent after the packets that are supposed come after it. This workaround will force a 500ms delay after the packet to ensure it has the best chance of coming first.
This should solve the "Waiting for Server" message for generally the first connection.