Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistencies with movement and position #699

Merged
merged 129 commits into from
Nov 20, 2020
Merged

Fix inconsistencies with movement and position #699

merged 129 commits into from
Nov 20, 2020

Conversation

Heath123
Copy link
Contributor

@Heath123 Heath123 commented May 30, 2020 •
edited
Loading

cache-chunks needs to be enabled in your config for the move fixes to take effect!

GeyserMC/mappings-generator#18 needs to be merged first

The same as #669 which was accidentality closed and the branch deleted

Move fixes V2 using bounding boxes
Currently fixes #548, #1008 and #617
Might fix #204

Known bugs that I can only fix when the custom collision boxes are in the release versions

  • Bamboo
  • Some grindstone things
  • Bugs with snow layers

Known bugs to fix

  • Sometimes when sprinting up stairs you get teleported back Fixed!
  • Snow layers are a bit buggy (disabling optimisations 2 and 3 at the same time seems to help) Mostly fixed, still has issues with different collision (not easily fixable but I'll try!)
  • Add proper hitboxes for: Now uses mappings
  • Fences and Walls (also with carpets on top)
  • Fence gates
  • Grindstone
  • Opening a fence gate, closing it and jumping is buggy
  • Door collision is buggy Fixed except for a specific arrangement
  • NCP Passable correction could be closer to a real client

Please tell me about any more bugs you find!

@Heath123 Heath123 mentioned this pull request May 30, 2020
Closed
5 tasks
@rtm516 rtm516 added PR: Bugfix When a PR contains a bugfix Work in Progress The issue is currently being worked on. labels May 30, 2020
@Heath123 Heath123 mentioned this pull request Jun 2, 2020
Closed
@Camotoy Camotoy marked this pull request as draft June 5, 2020 15:13
@WesleyVanNeck
Copy link
Contributor

is this even active?

@Heath123
Copy link
Contributor Author

is this even active?

Yes, it's very active, I just haven't pushed the latest changes yet. I have snow layers fixed etc.

@Heath123 Heath123 mentioned this pull request Jun 19, 2020
Closed
@Camotoy
Copy link
Member

Camotoy commented Jul 10, 2020

Just a heads-up that some .gradle stuff got thrown in with the latest commit.

@Heath123
Copy link
Contributor Author

Just a heads-up that some .gradle stuff got thrown in with the latest commit.

Ah, I'll fix that, thank you

@rtm516 rtm516 mentioned this pull request Jul 13, 2020
Closed
Camotoy
Camotoy requested changes Jul 20, 2020
View reviewed changes
Copy link
Member

@Camotoy Camotoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The mappings submodule got updated which seems unintentional.
  • There are still some Gradle files in the commit.
  • Why move the session jumping and sneaking variables to PlayerEntity>

connector/src/main/java/org/geysermc/connector/entity/PlayerEntity.java Outdated Show resolved Hide resolved
connector/src/main/java/org/geysermc/connector/network/session/cache/TeleportCache.java Outdated Show resolved Hide resolved
...va/org/geysermc/connector/network/translators/bedrock/BedrockBlockPickRequestTranslator.java Outdated Show resolved Hide resolved
.../main/java/org/geysermc/connector/network/translators/world/collision/CollisionRemapper.java Outdated Show resolved Hide resolved
@Heath123 Heath123 mentioned this pull request Jul 24, 2020
Closed
@Heath123
Copy link
Contributor Author

Fixes #1008

@Heath123
Copy link
Contributor Author

The player is kicked out of boats when entering
I believe this is caused by move fixes

I can get in boats

Heath123 and others added 16 commits November 13, 2020 19:42
@Heath123
Merge branch 'master' of https://github.com/GeyserMC/Geyser into move…
49736b7 
…-fixes
@Heath123
Merge branch 'move-fixes' of https://github.com/Heath123/Geyser into …
a7b6b79 
…move-fixes
@Camotoy
Merge branch 'master' of https://github.com/GeyserMC/Geyser into move…
426329c 
…-fixes
@Camotoy
First go at implementing Adapter support
c9b6b71
@Camotoy
Object-orient all the things
2497c63
@Camotoy
Work more on legacy support
6920b53
@Camotoy
Merge branch 'master' of https://github.com/GeyserMC/Geyser into move…
e2a2539 
…-fixes
@Camotoy
Add config option, fully update to 1.16.100
991b8c9
@Camotoy
Remove 0 air to JAVA_AIR_ID
9cce7de
@Camotoy
Remove unneeded override
7268694
@Tim203
Updated to latest adapters commit and fixes the double getWorld call
360db28
@Camotoy
Merge pull request GeyserMC#14 from Tim203/move-fixes
1ba0915 
Updated to latest adapters commit and fixes the double getWorld call
@Camotoy
Merge branch 'move-fixes' of https://github.com/Heath123/Geyser into …
f422c3b 
…move-fixes
@Camotoy
Update mappings and cache protocol path
b649f2e
@Camotoy
Cache protocol info for 1.12 -> 1.13 as it will always be the same
817a991
@Camotoy
Javadoc changes
d05c064
Heath123
Heath123 commented Nov 20, 2020
View reviewed changes
connector/src/main/resources/config.yml
# Whether to use direct server methods to retrieve information such as block states.
# Turning this off for Spigot will stop NMS from being used but will have a performance impact.
use-adapters: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an option for move fixes too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not opposed, I see no reason. There's not much reason people would want the move fixes off, and performance shouldn't be an issue. The reason that is an issue is in case there's a Spigot instance that breaks with them enabled.

Something that could be a config option is teleport ID confirmation flexibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the position and resend thresholds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@EasyClifton
Copy link
Contributor

When was this renamed?

@Camotoy
Copy link
Member

Camotoy commented Nov 20, 2020

I renamed it a couple weeks ago.

@Camotoy Camotoy merged commit a70d3e2 into GeyserMC:master Nov 20, 2020
@PappoYT PappoYT mentioned this pull request Nov 24, 2020
Closed
@soshimee
Copy link

Hmm, wonder why it says "sprinting up stairs," walking was the worst part for me, sprinting didn't have any issues.

@Chew Chew mentioned this pull request Dec 1, 2020
Closed
@Heath123 Heath123 deleted the move-fixes branch September 6, 2023 23:23
@max-sgt max-sgt mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hellohi3654 Hellohi3654 Hellohi3654 left review comments

@Camotoy Camotoy Camotoy approved these changes

@Redned235 Redned235 Redned235 left review comments

Assignees
No one assigned
Labels
PR: Bugfix When a PR contains a bugfix Work in Progress The issue is currently being worked on.
Projects
None yet
Milestone
No milestone