-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease cpu load to 30%. #60
Conversation
This doesn't actually resolve the problem, rather it's just a workaround. |
^ |
@@ -62,7 +62,11 @@ public void translate(ServerChunkDataPacket packet, GeyserSession session) { | |||
levelChunkPacket.setChunkX(packet.getColumn().getX()); | |||
levelChunkPacket.setChunkZ(packet.getColumn().getZ()); | |||
levelChunkPacket.setData(payload); | |||
session.getUpstream().sendPacket(levelChunkPacket); | |||
try { | |||
session.getUpstream().sendPacket(levelChunkPacket); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not how the connection being closed should be handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then how should it
CPU usage is very low (1%) when flying around, but chunks randomly stop loading and in general the chunk loading is very very slow. In general it seems like the view distance is decreased. Chunks up to 4 chunks away from the player load fast, everything farther away does not load at all or loads very slow. |
It’s because this doesn’t actually solve the problem. @EOT3000 if you come up with a solution, please open a new PR. |
The view distance doesn't decrease, because the server sends the chunks and decides how much you can see, we don't change that. Flickering is when the server sends a chunk update, this happens for example when walking far away from a chunk and coming back at it (and call the others unloaded). Those chunks will stay (for whatever reason) in memory until you switch dimension or quit. The issues can probably be fixed but anyway thanks for saying it. |
Create geyser-build-branch.yml
Need review, fixes #58