Refactor GameProtocol to remove version slash-combinations #4979
+104
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onebeastchris
approved these changes
Aug 21, 2024
Konicai
added
the
PR: Cosmetic
Kas-tle
approved these changes
Aug 22, 2024
Tim203
reviewed
Aug 24, 2024
| @@ -84,7 +84,7 @@ public final class GeyserServer { | |||
| /* | |||
| The following constants are all used to ensure the ping does not reach a length where it is unparsable by the Bedrock client | |||
| */ | |||
| private static final String PING_VERSION = pingVersion(); | |||
| private static final String PING_VERSION = GameProtocol.DEFAULT_BEDROCK_CODEC.getMinecraftVersion(); | |||
There was a problem hiding this comment.
I'm not against this, but one thing that should be noted here is that because we no longer override minecraftVersion the ping version will now become 1.21.20 instead of 1.21.21 (which was the version that'd show in the ping before this PR)
|
|
|
thanks |
|
These changes need to be re-tested |
…ctor-gameprotocol # Conflicts: # core/src/main/java/org/geysermc/geyser/network/UpstreamPacketHandler.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
bedrockVersionsfield in Geyser dumps has the same effective change ^api changes
GeyserApI#supportedBedrockVersions()now returns a list whose MinecraftVersions are all a single minecraft version; no slash combinations. This means there are multiple MinecraftVersions in the list of that same protocol version, but the minecraft versions are actually parseable.other notes
Unrelated to this PR, disconnect messages for outdated clients for versions >=622 and <712 are currently broken. CloudburstMC/Protocol#255 will allow us to fix that in the future.