Improve node ordering when updating configs #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the position of nodes modified or created during migrations does not differ from the config classes. For example, renaming the key of a node no longer results in the node being at the end of the map it belongs to.
I need to do some more testing for ConfigurateCommentMover, along with unit tests, as I've made some changes since last testing it, but it isn't actually triggered currently as described in the code.
A remaining issue (unrelated to this PR) is that due to the behaviour of configurate-interfaces, and the usage of subclasses of GeyserConfig, the subclass methods that add nodes or update comments are promoted to the top of the generated class. In other words, the ordering does not respect that declared in GeyserConfig.
For example with plugin impls, the following are promoted to the top of their sections:
clone-remote-portI would really like to not see this. Unfortunately I don't have time to improve configurate-interfaces currently.