Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension update folder #4929

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

rtm516
Copy link
Member

@rtm516 rtm516 commented Aug 2, 2024

Adds an update folder that can be used by extensions to update themselves on boot. Works a lot like the normal Spigot/Paper one.

Requires GeyserMC/languages#136 Merged

Also moves to using Files.list for finding jars as we only want to try and load them from the root extensions folder and not recursively look for them

@rtm516 rtm516 added the PR: Feature When a PR implements a new feature label Aug 2, 2024
@rtm516 rtm516 requested a review from Konicai August 9, 2024 12:55
Copy link
Member

@Konicai Konicai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please test what happens when there are multiple of the same extension in the update folder, or multiple in the extensions folder

@onebeastchris
Copy link
Member

Duplicate extensions in the "normal" extensions folder will be caught & warned about when loading the extensions at the 3rd stage. As for duplicate update entries... they would currently just be all put in the extensions folder and result in the same duplicate extension warning

@Konicai
Copy link
Member

Konicai commented Aug 10, 2024

Duplicate extensions in the "normal" extensions folder will be caught & warned about when loading the extensions at the 3rd stage

fair, but both could be replaced to ensure the new jar is the one that gets loaded

As for duplicate update entries... they would currently just be all put in the extensions folder and result in the same duplicate extension warning

would be nice to avoid

@rtm516 rtm516 requested a review from Konicai August 10, 2024 10:06
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor nitpicks

@onebeastchris
Copy link
Member

ready for merge, just needs to be documented on the wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extensions PR: Feature When a PR implements a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants