-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension update folder #4929
base: master
Are you sure you want to change the base?
Conversation
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
…onLoader.java Co-authored-by: chris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also please test what happens when there are multiple of the same extension in the update
folder, or multiple in the extensions
folder
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
Duplicate extensions in the "normal" extensions folder will be caught & warned about when loading the extensions at the 3rd stage. As for duplicate update entries... they would currently just be all put in the extensions folder and result in the same duplicate extension warning |
fair, but both could be replaced to ensure the new jar is the one that gets loaded
would be nice to avoid |
…onLoader.java Co-authored-by: Konicai <[email protected]>
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor nitpicks
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/extension/GeyserExtensionLoader.java
Outdated
Show resolved
Hide resolved
ready for merge, just needs to be documented on the wiki |
Adds an
update
folder that can be used by extensions to update themselves on boot. Works a lot like the normal Spigot/Paper one.Requires GeyserMC/languages#136MergedAlso moves to using
Files.list
for finding jars as we only want to try and load them from the root extensions folder and not recursively look for them