Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement full operator support #486

Closed
wants to merge 4 commits into from
Closed

Implement full operator support #486

wants to merge 4 commits into from

Conversation

lukeeey
Copy link
Member

@lukeeey lukeeey commented May 5, 2020

Introduction

This pull request allows you to change your game mode, the world difficulty, default game mode and game rules from in-game. Additionally, coordinates will now be hidden if the reducedDebugInfo game rule (which only exists in java edition) is enabled.

Due to an issue with MCProtocolLib, difficulty changing is currently disabled.

I have shoved a few things in WorldManager so i can override it if Geyser is run as a bukkit plugin which probably wasnt the best way to go about it, but im making this PR now for feedback.

@lukeeey
Copy link
Member Author

lukeeey commented May 6, 2020

I’ll make an issue at MCProtocolLib if I remember about the ClientSetDifficultyPacket, I’m out now though so can’t really

@lukeeey
Copy link
Member Author

lukeeey commented May 13, 2020

This can be further improved when plugin messaging support is added for Floodgate, as then we dont need to use the hacky method of sending the /gamemode or /defaultgamemode or /gamerule command in chat

@lukeeey lukeeey added PR: Feature When a PR implements a new feature Work in Progress The issue is currently being worked on. labels May 13, 2020
@mtsr
Copy link

mtsr commented Jul 9, 2020

I'd be interested in (helping) fixing the showCoordinates. What's holding up this PR besides a good rebase? Is there any significant rework needed? Want me to pick it up and finish it?

@lukeeey
Copy link
Member Author

lukeeey commented Jul 10, 2020

It’s not fully done and I’m too busy to work on it

@Heath123
Copy link
Contributor

It’s not fully done and I’m too busy to work on it

They're asking what they need to finish to get it ready to be merged, not why it isn't ready I think

@mtsr
Copy link

mtsr commented Jul 11, 2020

Exactly. I just want to know if and what I can do to help. I'll find my way around the code, mostly need some help with the conceptual side and architecture/design of geyser.

  • Is this PR still in line with the design for Geyser or does it need conceptual changes? In particular is the WorldManager approach OK, or can we come up with a different approach?
  • Does it need any implementation changes or does it just need finishing?
  • Is there other functionality that needs to be added, i.e. more operator functionality?
  • Are you OK with me picking up some of the work?

rtm516 added a commit to rtm516/Geyser that referenced this pull request Jul 27, 2020
@rtm516 rtm516 mentioned this pull request Jul 27, 2020
6 tasks
@Redned235
Copy link
Member

Superseded by #1035.

@Redned235 Redned235 closed this Jul 27, 2020
Redned235 added a commit that referenced this pull request Aug 8, 2020
* Port code from #486

Co-authored-by: Luke <[email protected]>

* Fix and clean code and add default gamemode changing

* Clean copyright

* Remove direct modification of server, clean up code and add player list xuid fetching.

* Move to custom settings menu

* Move sendAdventureSettings to GeyserSession

* Add javadoc comments

* Add translation support

* Remove updated copyright

* Clean up

* Clarify some javadoc comments

* Remove obsolete code

* Update languages submodule

* Fix javadoc comments

* Fix compile

Co-authored-by: Luke <[email protected]>
Co-authored-by: Redned <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature When a PR implements a new feature Work in Progress The issue is currently being worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants