Fix: Bedrock players dying of fall damage, instead of falling in the void #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konicai
reviewed
Jun 3, 2024
core/src/main/java/org/geysermc/geyser/entity/type/player/SessionPlayerEntity.java
Show resolved
Hide resolved
…void # Conflicts: # core/src/main/java/org/geysermc/geyser/entity/type/player/SessionPlayerEntity.java
onebeastchris
added
the
PR: Needs review
Camotoy
approved these changes
Jun 21, 2024
onebeastchris
removed
the
PR: Needs review
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
…void (GeyserMC#4704) * fix GeyserMC#4649 * add javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should properly teleport players below the Bedrock void floor - such a Bedrock thing - when they're falling. Additionally, this attempts to keep track of the Bedrock player's desynched position so we don't actually teleport on the Java end. This is restored when we're teleported, respawned, or moved servers to ensure we don't desync when we don't need to.
Fixes #4649, fixes #3738