Fix crafting output not updating sometimes #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camotoy
approved these changes
May 26, 2024
|
On second thought, maybe add a comment so people in the future know what the logic in the placement was. |
|
Added some comments, so that it's easier infer-able why the future is canceled after it is ensured that its the crafting grid result slot and that the inventory contains a crafting grid. |
onebeastchris
approved these changes
May 27, 2024
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
* Only cancel crafting grid future if slot == 0 * Add some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crafting recipes are updated within a future, but this future is canceled on any ContainerSetSlotPacket, it should be enough to only cancel the future when the output slot is directly affected.
As on our server the input slots are sent after the output slot is updated which causes that the recipe is never sent. (non-registered/procedural custom recipe)