Match Advancement Packet Behavior Towards Java #4684
Conversation
|
While I'm at it, does Geyser/Bedrock have a way to detect forms closing? The Java client sends a "advancements closed" packet whenever the user closes them. |
|
Look for a response handler for the given form - you can't send multiple options for a form (I.E. you input all your responses, then click "OK", or you click on the button of a simple form), so a response given means the form is closed unless the server re-sends it. Seems like that behavior might be implemented, but of course it can use another lookover. https://github.com/GeyserMC/Geyser/blob/master/core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java#L138 |
|
I just tested it and it does send the packet when the advancement list form is closed. However, when the form for a single advancement is closed no packet is sent. Should I add that in this PR or create a separate one? |
|
Feel free to add onto this PR. |
|
Seems to work as intended from my testing now. |
* Send advancement packet regardless of current tab * Send advancement close packet when single-advancement form closed
The client sends a "advancement tab open" packet whenever any tab is opened, not necessarily when a new one is switched to. This removes the if statement and sends the packet to the server regardless.