Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Make connection data exposed in api less prone to throw errors #4604

Merged
merged 5 commits into from
May 10, 2024
Merged

Feat: Make connection data exposed in api less prone to throw errors #4604

merged 5 commits into from
May 10, 2024

Conversation

onebeastchris
Copy link
Member

This should ensure that calling e.g. connecton.xuid() in certain scenarious would actually give a non-null xuid.
Currently, this would fail in the following cases:

  • SessionInitializeEvent: was fired before we parsed the auth/client data
  • SessionDisconnectEvent: Can occur when disconnect happens before we parse the auth or client data (e.g. when we shut down, when a bedrock player joining is invalid, etc)

@onebeastchris onebeastchris added the API The issue/feature request relates to the Geyser API label Apr 25, 2024
@Camotoy
Copy link
Member

Camotoy commented Apr 25, 2024

Test with GeyserConnect to make sure it still works?

onebeastchris added a commit to onebeastchris/GeyserConnect that referenced this pull request May 10, 2024
@onebeastchris
Changes to ensure GeyserConnect still works despite internal changes in
9f2e46a 
GeyserMC/Geyser#4604
@onebeastchris onebeastchris mentioned this pull request May 10, 2024
Merged
@onebeastchris onebeastchris added the PR: Bugfix When a PR contains a bugfix label May 10, 2024
@onebeastchris onebeastchris merged commit e697eb3 into GeyserMC:master May 10, 2024
2 checks passed
@onebeastchris onebeastchris deleted the api-fixes branch May 10, 2024 21:58
onebeastchris added a commit to GeyserMC/GeyserConnect that referenced this pull request May 10, 2024
@onebeastchris
Changes to ensure GeyserConnect still works despite internal changes in
9733781 
GeyserMC/Geyser#4604 (#83)
XingLingQAQ pushed a commit to XingLingQAQ/Geyser that referenced this pull request Sep 25, 2024
@onebeastchris @XingLingQAQ
Feat: Make connection data exposed in api less prone to throw errors (G…
2aadfcf 
…eyserMC#4604)

* Feat: Make connection data exposed in api less prone to throw errors

* address reviews

* review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Konicai Konicai Konicai approved these changes

@rtm516 rtm516 rtm516 approved these changes

Assignees
No one assigned
Labels
API The issue/feature request relates to the Geyser API PR: Bugfix When a PR contains a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onebeastchris @Camotoy @rtm516 @Konicai