Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lecterns #424

Closed
wants to merge 4 commits into from
Closed

Implement lecterns #424

wants to merge 4 commits into from

Conversation

Foorcee
Copy link
Contributor

@Foorcee Foorcee commented Apr 25, 2020

No description provided.

� Conflicts:
�	connector/src/main/java/org/geysermc/connector/network/translators/inventory/PlayerInventoryTranslator.java
@Camotoy Camotoy added the PR: Feature When a PR implements a new feature label May 14, 2020
@Preloading
Copy link

Uhh Looking at all the incompatibility I think this needs to be redone...

@Camotoy
Copy link
Member

Camotoy commented Oct 1, 2020

I'm closing this, as I have an updated branch that implements Force's work and adds support for the lectern inventory.

Unfortunately, limitations of the lectern on Bedrock means that it cannot be fully implemented on Java without hiccups. On Java Edition, the lectern is technically an inventory, and the first slot is the book of the lectern. On Bedrock, a lectern's contents are a part of the block entity tag. We don't have access to the lectern's contents until they are opened. The first time Bedrock opens a lectern, therefore, it reads the blank book tag. The book tag cannot be changed clientside while Bedrock has it opened - the book page can. TL;DR: You need to click a lectern twice for it to show its true contents. I can PR this but after spending two days on it I'm rather frustrated at the mechanics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature When a PR implements a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants