Fix forced zoom issue when switching into spectator mode, use new spectator mode #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onebeastchris
added
PR: Feature
Camotoy
approved these changes
Sep 6, 2023
Konicai
reviewed
Sep 6, 2023
core/src/main/java/org/geysermc/geyser/entity/type/player/SessionPlayerEntity.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #4022, fix #3896, and fix #3413
BDS sends the following when switching into spectator mode:
https://paste.gg/p/anonymous/8f96ea38ebbb46b389fb08af5120e7d7
This PR makes sure the spectator layer is set additionally to the base layer, so the forced zoom isnt present (tested by rapidly switching between gamemodes, which was an easy way to trigger the bug)
Opening as a draft as i am hoping to resolve #3318 with this same PR; not sure what's missing for that though (yet)
Edit: Fixes #3318 by not sending updated flags while in spectator mode. E.g. sending the
onFireorSPRINTINGflag also cause the update - additionally, this makes sure spectator mode players dont see fire when in lava (same on BDS/java edition).