Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Merchant Inventory Transaction #1017

Merged
merged 2 commits into from
Jul 26, 2020

Conversation

bundabrg
Copy link
Collaborator

Add fix for Villager Trading

@Camotoy
Copy link
Member

Camotoy commented Jul 25, 2020

!start-test-server

@geysermc-services
Copy link

geysermc-services bot commented Jul 25, 2020

Preparing and starting test server as requested by @DoctorMacc at 2020-07-25 14:17:59 UTC

Downloading Geyser Standalone...

Finished download, setting up docker container...

Built docker container.

Connect via 51.210.124.95:32795 (minecraft://?addExternalServer=Test%20PR%231017|51.210.124.95:32795)

@Heath123
Copy link
Contributor

This works for me

@Camotoy
Copy link
Member

Camotoy commented Jul 25, 2020

Works fine on the test server; I could not take emeralds out of the slot though (did not test with a villager with two slots)

@bundabrg
Copy link
Collaborator Author

Good to know. I'll look at that tomorrow.

@bundabrg
Copy link
Collaborator Author

Ok, so far #763 works perfectly. This one has an issue on a tablet where when trading the source item is left in the cursor (or more likely it thinks its in the cursor). I suspect its related to a refresh after the click or perhaps Geyser thinks the cursor has something in it when java does not.

… as well.

Tested on tablet but not desktop yet.
@Camotoy
Copy link
Member

Camotoy commented Jul 26, 2020

!start-test-server

@geysermc-services
Copy link

geysermc-services bot commented Jul 26, 2020

Preparing and starting test server as requested by @DoctorMacc at 2020-07-26 02:51:09 UTC

Downloading Geyser Standalone...

Finished download, setting up docker container...

Failed creating and starting docker container.
Error: (HTTP code 409) unexpected - Conflict. The container name "/geyser-pr-1017" is already in use by container "c4d75def6ceaffde1a9986d8b2efd7044d05dcfe52d6e33ed7f24beb8c8459d4". You have to remove (or rename) that container to be able to reuse that name.

@Camotoy
Copy link
Member

Camotoy commented Jul 26, 2020

!stop-test-server

@geysermc-services
Copy link

geysermc-services bot commented Jul 26, 2020

Stopping and removing test server as requested by @DoctorMacc at 2020-07-26 02:53:41 UTC

Unable to stop and remove test server.
Error: (HTTP code 404) no such container - No such container: geyser-pr-1017

@Camotoy
Copy link
Member

Camotoy commented Jul 26, 2020

!start-test-server

@geysermc-services
Copy link

geysermc-services bot commented Jul 26, 2020

Preparing and starting test server as requested by @DoctorMacc at 2020-07-26 02:53:55 UTC

Downloading Geyser Standalone...

Finished download, setting up docker container...

Built docker container.

Connect via 51.210.124.95:32796 (minecraft://?addExternalServer=Test%20PR%231017|51.210.124.95:32796)

@Camotoy
Copy link
Member

Camotoy commented Jul 26, 2020

Works fine for me on desktop.

@Camotoy Camotoy linked an issue Jul 26, 2020 that may be closed by this pull request
@Camotoy
Copy link
Member

Camotoy commented Jul 26, 2020

As villager trading is hotly requested for a fix, I'll be merging this until the inventory rewrite is finished. Thanks for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.16] Players cannot trade with villagers.
3 participants