Disable fireworks for consoles (Addresses #1083, #1164)

Not ideal, but there isn't a whole lot we can do as this is a game bug within console versions.
GeyserMC · Aug 18, 2020 · 6db56fd · 6db56fd
1 parent 8c514d9
commit 6db56fd
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/connector/src/main/java/org/geysermc/connector/entity/FireworkEntity.java b/connector/src/main/java/org/geysermc/connector/entity/FireworkEntity.java
@@ -40,6 +40,7 @@
 import org.geysermc.connector.network.session.GeyserSession;
 import org.geysermc.connector.utils.FireworkColor;
 import org.geysermc.connector.utils.MathUtils;
+import org.geysermc.floodgate.util.DeviceOS;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -64,6 +65,12 @@ public void updateBedrockMetadata(EntityMetadata entityMetadata, GeyserSession s
                 return;
             }
 
+            // TODO: Remove once Mojang fixes bugs with fireworks crashing clients on these specific devices.
+            // https://bugs.mojang.com/browse/MCPE-89115
+            if (session.getClientData().getDeviceOS() == DeviceOS.XBOX_ONE || session.getClientData().getDeviceOS() == DeviceOS.ORBIS) {
+                return;
+            }
+
             CompoundTag fireworks = tag.get("Fireworks");
 
             NbtMapBuilder fireworksBuilder = NbtMap.builder();