Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20.2 Support #449

Merged
merged 12 commits into from
Sep 26, 2023
Merged

1.20.2 Support #449

merged 12 commits into from
Sep 26, 2023

Conversation

Kas-tle
Copy link
Member

@Kas-tle Kas-tle commented Sep 23, 2023 •
edited
Loading

Also added support for Eclipse IDE so I could actually work on it...

Issues Addressed

Spigot

  • PacketHandshakingInSetProtocol is now a record so we must construct call its constructor instead of modifying
    • Unfortunately this requires 2 ints with the same access level, so we must specify obfuscated field names
  • initUUID gone and that info is now passed directly to the event via LoginHandler().fireEvents(GameProfile)
  • There are now multiple PacketListener fields in NetworkManager, so we must specify the obfuscated field name

Paper

  • Also works with proposed Spigot changes per their experimental builds

Velocity

Note that this is based on the current PR for 1.20.2 support on the Velocity repo: PaperMC/Velocity#1088

  • Bump API to 3.2.0-SNAPSHOT
  • Bump minimum Java version to 11 per Velocity API
  • getSessionHandler is now getActiveSessionHandler

Bungeecord

Works without changes (truly shocking).

@Kas-tle
Spigot 1.20.2
894aa22 
Signed-off-by: Joshua Castle <[email protected]>
@Kas-tle Kas-tle linked an issue Sep 23, 2023 that may be closed by this pull request
Error while enabling #448
Closed
@Kas-tle
Oops
1149be0 
Signed-off-by: Joshua Castle <[email protected]>
@Kas-tle
1.20.2 velocity (#1)
8ee2c95 
* 1.20.2 Velocity

Signed-off-by: Joshua Castle <[email protected]>

* Archive build artifacts

Signed-off-by: Joshua Castle <[email protected]>

* Fix typo in velocity-plugin.json

Signed-off-by: Joshua Castle <[email protected]>

---------

Signed-off-by: Joshua Castle <[email protected]>
@Kas-tle Kas-tle changed the title Spigot 1.20.2 Support 1.20.2 Support Sep 23, 2023
@Kas-tle
Fix formatting and apply codestyle to eclipse
ca654f1 
Signed-off-by: Joshua Castle <[email protected]>
@Kas-tle
Ignore changes to core base prefs
f56ef5a 
Signed-off-by: Joshua Castle <[email protected]>
@Kas-tle
Proper ignore
71b9082 
Signed-off-by: Joshua Castle <[email protected]>
@Kas-tle
Remove buildship prefs
409d90d 
Signed-off-by: Joshua Castle <[email protected]>
@onebeastchris onebeastchris mentioned this pull request Sep 24, 2023
Closed
@rogerxavier93 rogerxavier93 mentioned this pull request Sep 25, 2023
Closed
Tim203
Tim203 requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Tim203 Tim203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, just a few nitpicks

spigot/src/main/java/org/geysermc/floodgate/addon/data/SpigotDataHandler.java Outdated Show resolved Hide resolved
spigot/src/main/java/org/geysermc/floodgate/util/ClassNames.java Outdated Show resolved Hide resolved
spigot/src/main/java/org/geysermc/floodgate/util/ClassNames.java Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@Kas-tle Kas-tle linked an issue Sep 25, 2023 that may be closed by this pull request
Error occurred while enabling floodgate (1.20.2) #451
Closed
@Kas-tle Kas-tle requested a review from Tim203 September 25, 2023 18:17
@Tim203 Tim203 merged commit 26c11bd into GeyserMC:master Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim203 Tim203 Tim203 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error occurred while enabling floodgate (1.20.2) Error while enabling
2 participants
@Kas-tle @Tim203