Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing siteurl on single host #32

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Conversation

brianweet
Copy link
Contributor

Fixes #27

@brianweet brianweet requested a review from marisks March 3, 2022 15:16
Copy link
Member

@marisks marisks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I see that @Model.ShowHostsLabel was always true and it always rendered a label - also when a dropdown was visible. Don't we need a label for dropdowns?

@brianweet
Copy link
Contributor Author

ShowHostsLabel was only set to true if there was just 1 host (I removed the part from an if .. else statement)

@brianweet
Copy link
Contributor Author

And regarding the label in the UI. We should just clean it up completely, the UI is quite messy at the moment. I will create a new issue for that.

@brianweet brianweet requested a review from marisks March 4, 2022 09:50
@brianweet brianweet merged commit c5df6cf into master Mar 4, 2022
@brianweet brianweet deleted the fix/missing-siteurl branch March 4, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when generating sitemap when the current website has only 1 host set up
2 participants