[Fix]SetPublisher track setUp race condition #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
ipavlidakis
force-pushed
the
fix/set-publisher-race-condition
branch
from
04795f6
to
834649d
Compare
martinmitrevski
approved these changes
Oct 30, 2024
| // update.supportsGrouping = true | ||
| // update.supportsHolding = true | ||
| // update.supportsUngrouping = true | ||
| // update.supportsGrouping = true |
There was a problem hiding this comment.
can we delete this code?
ipavlidakis
force-pushed
the
fix/set-publisher-race-condition
branch
from
bdd3002
to
c52ca4c
Compare
ipavlidakis
force-pushed
the
fix/set-publisher-race-condition
branch
from
c52ca4c
to
b72402a
Compare
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://stream-io.atlassian.net/browse/PBE-6301
📝 Summary
In some cases, a race condition was hit, where Publisher setUp hasn't completed when the negotiation was executing. That resulted in SetPublisherRequest tracks being empty.
🛠 Implementation
Before negotiation, we add a small expectation (setUp must complete before proceeding) and allowing a 2 seconds waiting time for it.
☑️ Contributor Checklist