Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]MissingPermission error thrown when connectUser shouldn't be called #525

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

ipavlidakis
Copy link
Collaborator

📝 Summary

Even though connectUser isn't supposed to be called for anonymous, it seems that we are calling it anyway (but ignoring the error). This revision checks user type and avoids calling connectUser for anonymous.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Sep 18, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 18, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 18, 2024 10:17
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 18, 2024

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.4 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.32 MB 2.32 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

Copy link

sonarcloud bot commented Sep 18, 2024

@ipavlidakis ipavlidakis merged commit b223fdc into develop Sep 18, 2024
13 checks passed
@ipavlidakis ipavlidakis deleted the improvement/anonymous-flow branch September 18, 2024 11:23
This was referenced Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants