Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]Provide call rejection reason #449

Merged

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Jun 26, 2024

🎯 Goal

Provide a rejection reason based on this specification.

🛠 Implementation

Rejection reason should be added only on methods handling explicit user requests (we shouldn't include any rejection reason in methods that respond to call events).

Due to changes the following breaking changes have been introduced as they remove unnecessary code from IncomingCallViewModel

  • the hideIncomingCallScreen property
  • the stopTimer method.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Jun 26, 2024
@ipavlidakis ipavlidakis self-assigned this Jun 26, 2024
@ipavlidakis ipavlidakis marked this pull request as ready for review June 27, 2024 11:22
@ipavlidakis ipavlidakis requested a review from a team as a code owner June 27, 2024 11:22
@ipavlidakis ipavlidakis force-pushed the enhancement/add-rejection-reason-on-usera-actions branch 3 times, most recently from b81dff3 to d592175 Compare June 27, 2024 11:58
@ipavlidakis ipavlidakis force-pushed the enhancement/add-rejection-reason-on-usera-actions branch from f6543af to ad5dfc1 Compare July 2, 2024 10:04
@ipavlidakis ipavlidakis force-pushed the enhancement/add-rejection-reason-on-usera-actions branch from ad5dfc1 to 7b3ca93 Compare July 2, 2024 10:24
Copy link

sonarcloud bot commented Jul 2, 2024

@ipavlidakis ipavlidakis enabled auto-merge (squash) July 2, 2024 10:47
@ipavlidakis ipavlidakis merged commit 1918ffe into develop Jul 2, 2024
14 checks passed
@ipavlidakis ipavlidakis deleted the enhancement/add-rejection-reason-on-usera-actions branch July 2, 2024 11:15
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants