feat(push_notification): add pushprovider update and test #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
peterdeme
force-pushed
the
push-settings
branch
3 times, most recently
from
f03f437
to
02e447e
Compare
peterdeme
commented
Apr 6, 2022
driver-devel
reviewed
Apr 7, 2022
peterdeme
force-pushed
the
push-settings
branch
from
416b74a
to
109e1d2
Compare
| apn_team_id | ||
| apn_topic | ||
|
|
||
| firebase_credentials |
There was a problem hiding this comment.
For v2 we have:
- firebase_notification_template
- firebase_apn_template
There was a problem hiding this comment.
I'll need this PR to be merged first: GetStream/stream-chat-go#218
There was a problem hiding this comment.
we can still provide firebase_apn_template and firebase_notification_template. why did you drop them?
There was a problem hiding this comment.
from where? it's there
There was a problem hiding this comment.
himm, it wasn't there but it was a commit diff I guess. Looks fine
peterdeme
force-pushed
the
push-settings
branch
from
c4e9b82
to
e5e9121
Compare
ferhatelmas
approved these changes
Apr 26, 2022
|
@ferhatelmas added ✅ |
peterdeme
added a commit
that referenced
this pull request
Apr 27, 2022
peterdeme
added a commit
that referenced
this pull request
Apr 27, 2022
peterdeme
added a commit
that referenced
this pull request
Apr 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.