-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-1491] Add custom modal transition for message list #1760
[CIS-1491] Add custom modal transition for message list #1760
Conversation
5e9e8a6
to
fa16d6c
Compare
b68c9c0
to
11816c0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1760 +/- ##
===========================================
- Coverage 85.39% 85.37% -0.02%
===========================================
Files 234 234
Lines 11247 11247
===========================================
- Hits 9604 9602 -2
- Misses 1643 1645 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left couple of more comments here
Sources/StreamChatUI/ChatChannel/StreamModalTransitioningDelegate.swift
Outdated
Show resolved
Hide resolved
We are trying to present the chat in a modal using |
🔗 Issue Link
CIS-1491
#1307
🎯 Goal
Introduces a custom modal transition to workaround the inverted table view on the message list. This custom transition should be used if you as a customer need to present the
ChatChannelVC
in a modal.Usage:
🛠 Implementation
Adds a new
StreamModalTransitioningDelegate
that mimics the native's modal transition.🎨 Changes
ModalTransition.mp4
🧪 Testing
Check the video on how to test this in the demo app.
☑️ Checklist