Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cant react(reaction) a message in stream-chat-react version 12 #2583

Closed
yudhistiraak opened this issue Dec 18, 2024 · 7 comments · Fixed by #2584
Closed

bug: cant react(reaction) a message in stream-chat-react version 12 #2583

yudhistiraak opened this issue Dec 18, 2024 · 7 comments · Fixed by #2584
Labels
bug Something isn't working released on @latest status:confirmed Described issue has been reproduced by the repo maintainer

Comments

@yudhistiraak
Copy link

yudhistiraak commented Dec 18, 2024

Describe the bug

when im send message and react it, the reaction selector doesnt open

To Reproduce
Steps to reproduce the behavior:

Go to main chat screen
Click on open reaction icon button in message list
Expected behavior

i've tried any version, doesnt work on version 12 up

https://drive.google.com/file/d/1TAq_uPPIy1pjCVAHVWPRO8zmfCnxih_m/view?usp=drive_link

Package version

stream-chat: ^8.45.0,
stream-chat-react": ^12.6.0

@yudhistiraak yudhistiraak added bug Something isn't working status: unconfirmed labels Dec 18, 2024
@MartinCupela
Copy link
Contributor

@yudhistiraak we will need more information about you customizations to message list. Also is this a development environment with strict mode?

the google drive link is not accessible publicly.

As can be seen in the demo, the selector opens.

@yudhistiraak
Copy link
Author

yudhistiraak commented Dec 18, 2024

development environment with strict mode? yes
im already open the google drive link, please check it https://drive.google.com/file/d/1TAq_uPPIy1pjCVAHVWPRO8zmfCnxih_m/view?usp=sharing

@MartinCupela
Copy link
Contributor

Could you please share the sandbox from your video?

@yudhistiraak
Copy link
Author

yudhistiraak commented Dec 18, 2024

the sandbox is from https://getstream.io/chat/react-chat/tutorial/
try install the stream-chat-react ^12 up

@MartinCupela
Copy link
Contributor

I am not able to reproduce the issue from your video. As can be seen from the screenshots, I am able to open the reaction selector, both on the tutorial page as well as on the sandbox page. Have you performed any customizations to the sandbox?

image image

@yudhistiraak
Copy link
Author

yudhistiraak commented Dec 18, 2024

in that sandbox tutorial the stream-chat-react version is ^11.15.0 with stream-chat ^ 8.26.0 , please check it at package.json.
then change it with ^12.xx.xx version to see the bug

my packages:
stream-chat: ^8.45.0,
stream-chat-react": ^12.6.0

@myandrienko myandrienko added status:confirmed Described issue has been reproduced by the repo maintainer and removed status: unconfirmed labels Dec 18, 2024
myandrienko added a commit that referenced this issue Dec 19, 2024
### 🎯 Goal

When the `useDialog` hook's component unmounts, it immediately clears
dialog state in an effect cleanup. However, in some situations an effect
cleanup can run even if the hook's component is still mounted and
effect's dependencies didn't change - e.g., when `<StrictMode />` is
enabled.

So it's safer to keep dialog state for a short time after cleanup runs.

### 🛠 Implementation details

Instead of immediately removing dialog state, it's marked to be removed
after a short timeout. Referencing the dialog again quick cancels state
removal.

Fixes #2583.
github-actions bot pushed a commit that referenced this issue Dec 19, 2024
## [12.8.1](v12.8.0...v12.8.1) (2024-12-19)

### Bug Fixes

* do not clear dialog state immediately on useDialog unmount ([#2584](#2584)) ([a8755ec](a8755ec)), closes [#2583](#2583)
@stream-ci-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 12.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @latest status:confirmed Described issue has been reproduced by the repo maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants