Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message list connection reconciliation #2896

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: message list connection reconciliation #2896

merged 2 commits into from
Jan 17, 2025

Conversation

isekovanic
Copy link
Contributor

🎯 Goal

This PR fixes the problems mentioned in this GH issue.

  • The reconnect issue is a regression that happened in V6 of our SDK, where no actual HTTP calls were being done when trying to reconcile the state when recovering connection
  • The other one is an improper use of a hook within the SDK, causing the property to be ignored altogether (as the second time it is being invoked is deeper within the DOM tree)

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot
Copy link
Contributor

SDK Size

title develop branch diff status
js_bundle_size 463 KB 463 KB 0 B 🟢

@isekovanic isekovanic mentioned this pull request Jan 16, 2025
Closed
8 tasks
@isekovanic isekovanic merged commit 020cecc into develop Jan 17, 2025
5 checks passed
@isekovanic isekovanic deleted the fix/message-list-connection-reconciliation branch January 17, 2025 08:08
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushal87 khushal87 khushal87 approved these changes

@oliverlaz oliverlaz oliverlaz approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isekovanic @Stream-SDK-Bot @stream-ci-bot @oliverlaz @khushal87