-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for video recording take and upload #2870
Conversation
SDK Size
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we only doing this for Expo
?
Ignore this, I apparently cannot read :D All good ! |
Hey @isekovanic, I have added your suggested fixes. Please give it a final look. Thanks 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Looks good to me
This PR focuses on adding support for video recording using the camera.
We introduced a button for video recordings for Android since mixed type is not supported on Android. To test Android, use a real device instead of an emulator.
A button is added to the NativeAttachementPicker and AttachmentPicker for Android to support them.
Fixes #1763