Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for video recording take and upload #2870

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

khushal87
Copy link
Member

@khushal87 khushal87 commented Jan 2, 2025

This PR focuses on adding support for video recording using the camera.

We introduced a button for video recordings for Android since mixed type is not supported on Android. To test Android, use a real device instead of an emulator.

A button is added to the NativeAttachementPicker and AttachmentPicker for Android to support them.

Fixes #1763

@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Jan 2, 2025

SDK Size

title develop branch diff status
js_bundle_size 463 KB 463 KB +133 B 🟢

@khushal87 khushal87 marked this pull request as ready for review January 2, 2025 10:53
@khushal87 khushal87 changed the title feat: add support for video recording take and upload on iOS feat: add support for video recording take and upload Jan 6, 2025
Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we only doing this for Expo ?

@isekovanic
Copy link
Contributor

Are we only doing this for Expo ?

Ignore this, I apparently cannot read :D All good !

@khushal87
Copy link
Member Author

Hey @isekovanic, I have added your suggested fixes. Please give it a final look. Thanks 😄

Copy link
Contributor

@isekovanic isekovanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Looks good to me

@khushal87 khushal87 merged commit 7e50994 into develop Jan 15, 2025
5 checks passed
@khushal87 khushal87 deleted the video-recording-send-support-ios branch January 15, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No video record option available while camera is open in <MessageInput> component
3 participants