fix: audio recording default output #2858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes this Zendesk ticket.
This change also aligns our SDK's behaviour to be compatible with the other SDKs.
Since we did not have it before, this PR also exposes a native handler responsible for the overriding of any and all Audio options available through the libraries used (
react-native-audio-video-recorder
andexpo-av
). All configuration has been moved within theAudio
classes themselves and the native handler acts as a factory through which we can tailor the configuration however we want, without having to rewrite the entire module.Example usage:
With these couple of lines, we override the
AVModeIOS
property to be set togamechat
instead of the now defaultspokenaudio
. AllAudio
related types are now also exported from within the SDK and the various ones are marked asExpo
andRNCLI
adequately.Docs are available in this PR.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
develop
branch