Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio recording default output #2858

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

isekovanic
Copy link
Contributor

@isekovanic isekovanic commented Dec 20, 2024

🎯 Goal

Fixes this Zendesk ticket.

This change also aligns our SDK's behaviour to be compatible with the other SDKs.

Since we did not have it before, this PR also exposes a native handler responsible for the overriding of any and all Audio options available through the libraries used (react-native-audio-video-recorder and expo-av). All configuration has been moved within the Audio classes themselves and the native handler acts as a factory through which we can tailor the configuration however we want, without having to rewrite the entire module.

Example usage:

registerNativeHandlers({ overrideAudioRecordingConfiguration: (config: RNCLIAudioRecordingConfiguration) => {
    if (config?.options?.audioSet) {
      config.options.audioSet.AVModeIOS = AVModeIOSOption.gamechat;
    }
    return config;
  }});

With these couple of lines, we override the AVModeIOS property to be set to gamechat instead of the now default spokenaudio. All Audio related types are now also exported from within the SDK and the various ones are marked as Expo and RNCLI adequately.

Docs are available in this PR.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Dec 20, 2024

SDK Size

title develop branch diff status
js_bundle_size 456 KB 460 KB +4283 B 🔴

@isekovanic isekovanic merged commit d43a7b1 into develop Dec 23, 2024
7 of 8 checks passed
@isekovanic isekovanic deleted the fix/audio-recording-default-output branch December 23, 2024 13:48
@github-actions github-actions bot mentioned this pull request Dec 23, 2024
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants