Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes the occasional
regex maximum depth reached
error.Not going to go into the specifics on why this happens as they're complicated, but I will add a few bullet points:
simple-markdown
available here, but nothing changed with that and the issue is still noticeable\n
characters, followed by many white spaces; the regex state machine runs something similar to/\s+/g
at one point, which considers both. However, despite treating them both as the same character under\s
, it actually does a ridiculous amount of backtracking and combinations while all that's going on, even due to a single\n
character as it tries to look for every possible scenario.O(n)
.Note: We should really look into upgrading our markdown package in general. I was successful in doing so, but decided to separate this fix and the migration since deeper testing would be required.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
develop
branch