Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android poll creation modal size #2783

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

isekovanic
Copy link
Contributor

🎯 Goal

It appears that on version 0.76.0 of React Native and onwards Android modals are known to bug out if it is not immediately clear what the size of their parent is, even if it's enclosed and completely predictable. It's not entirely clear to me (yet) if this is a new architecture thing or something else. The change makes sure that the Modal's immediate parent is correct and signals the Android internals to properly calculate the size of the modal.

Special styling overrides to the modal are not given because:

  • This is something that is meant to be used internally (and I want it to stay that way), since integrators can always override the behaviour of the poll creation button and spin up their own modal if they need something specific
  • We anyway want to enforce the proper use of navigation components (through popular navigation libraries) to be the thing our integrators do for any type of navigation as it's impossible to handle every case with our own

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@isekovanic isekovanic changed the base branch from develop to v6.0.0 November 14, 2024 15:50
Copy link
Member

@oliverlaz oliverlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we backport this to v5 as well? There may be customers using 0.76 without new arch enabled.

@isekovanic
Copy link
Contributor Author

Shall we backport this to v5 as well? There may be customers using 0.76 without new arch enabled.

We can, yes - it's a small change so no biggie

@isekovanic isekovanic merged commit 81507fb into v6.0.0 Nov 14, 2024
2 of 3 checks passed
@isekovanic isekovanic deleted the fix/android-poll-creation-modal-size branch November 14, 2024 16:16
@isekovanic isekovanic mentioned this pull request Nov 14, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants