fix: android poll creation modal size #2783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
It appears that on version
0.76.0
of React Native and onwards Android modals are known to bug out if it is not immediately clear what the size of their parent is, even if it's enclosed and completely predictable. It's not entirely clear to me (yet) if this is a new architecture thing or something else. The change makes sure that theModal
's immediate parent is correct and signals the Android internals to properly calculate the size of the modal.Special styling overrides to the modal are not given because:
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
develop
branch