-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable typing events when offline #2753
Conversation
SDK Size
|
Yeah this is 100% broken @khushal87 & @oliverlaz :D I think it interchangeably gets confused between our v6 branch and anything that goes to develop, since: |
hey @testableapple can you please shed some light here? How does this calculation work under the hood? Do we have some caches that are messing up the reporting? |
Hey @oliverlaz, well, there is no caching. There is only one json file that is being updated on every merge to So every PR is measured and compared with the In regards to this issue, @isekovanic is right, the SDK Size action gets confused because of the push to v6 branch (it only expects pushes to |
Thanks so much @testableapple ! Do you have any advice for how to approach this whenever we do branch builds ? We sometimes need to do this in order to test on |
@isekovanic, here is the fix - #2755
Hmm, I don't see how this might be related 🤔 |
Ah, I misunderstood what you were saying - my bad. Ignore the last inquiry about branch builds 👍 |
🎉 This PR is included in version 5.41.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎯 Goal
Solves the
typing
errors mentioned in this GH issue.🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
develop
branch