Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Message.tsx render conditional #2733

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: improve Message.tsx render conditional #2733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
"devDependencies": {
"@commitlint/cli": "^12.1.4",
"@commitlint/config-conventional": "^12.1.4",
"@semantic-release/changelog": "^5.0.1",
"@semantic-release/exec": "^5.0.0",
"@semantic-release/git": "^9.0.0",
"@semantic-release/changelog": "^6.0.2",
"@semantic-release/exec": "^6.0.3",
"@semantic-release/git": "^10.0.1",
"dotenv": "^10.0.0",
"execa": "^5.1.1",
"husky": "^6.0.0",
"lerna": "^4.0.0",
"prettier": "3.3.3",
"semantic-release": "^17.4.4",
"semantic-release": "^19.0.5",
"uglify-js": "^3.19.2"
},
"husky": {
Expand Down
4 changes: 3 additions & 1 deletion package/src/components/Message/Message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,9 @@ const MessageWithContext = <
testID='message-wrapper'
>
<MessageSimple />
{isBounceDialogOpen && <MessageBounce setIsBounceDialogOpen={setIsBounceDialogOpen} />}
{isBounceDialogOpen ? (
<MessageBounce setIsBounceDialogOpen={setIsBounceDialogOpen} />
) : null}
{messageOverlayVisible ? (
<MessageMenu
dismissOverlay={dismissOverlay}
Expand Down
2 changes: 1 addition & 1 deletion release/next.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ configPromise.then((config) => {
{
name: 'v6.0.0',
channel: 'rc',
prerelease: true,
prerelease: 'rc',
},
],
}).then((result) => {
Expand Down
5 changes: 5 additions & 0 deletions release/release.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ module.exports = Promise.resolve().then(() => {
'@semantic-release/release-notes-generator',
{
preset: 'conventionalcommits',
parserOpts: {
mergePattern: mergeRegex,
noteKeywords: ['BREAKING CHANGE', 'BREAKING CHANGES'],
},
presetConfig: {
types: [
{
Expand Down Expand Up @@ -78,6 +82,7 @@ module.exports = Promise.resolve().then(() => {
const lernaPackage = require('../lerna.json');

return {
dryRun: true,
extends: [`${__dirname}/monorepo-setup.js`],
workspaces: lernaPackage.packages,
filterPath: process.env.FILTER_PATH,
Expand Down
Loading
Loading