Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly invert list manually android #2685

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

isekovanic
Copy link
Contributor

🎯 Goal

Fixes this Zendesk issue.

🛠 Implementation details

While inverting manually, we were inverting the entire CellRenderer component. Debugging how the FlatList rendering mechanism works, we can see that each Cell within it comprises of 2 parts: the ListItem component (which renderItem spits out) and the ItemSeparatorComponent just below it. By inverting the Cell we would invert the entire composition, while we should be really inverting them separately.

Also fixes an issue where the ItemSeparatorComponent was not being inverted properly (noticeable if you would add text to it for example, since we'd never invert this).

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot
Copy link
Contributor

Stream-SDK-Bot commented Sep 20, 2024

SDK Size

title develop branch diff status
js_bundle_size 442.099609375 KB 442 KB 0 B 🟢

@isekovanic isekovanic merged commit 2b5bf07 into develop Sep 23, 2024
7 checks passed
@isekovanic isekovanic deleted the fix/android-workaround-list-inversion branch September 23, 2024 12:35
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.38.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants