fix: properly invert list manually android #2685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes this Zendesk issue.
🛠 Implementation details
While inverting manually, we were inverting the entire
CellRenderer
component. Debugging how theFlatList
rendering mechanism works, we can see that eachCell
within it comprises of 2 parts: theListItem
component (whichrenderItem
spits out) and theItemSeparatorComponent
just below it. By inverting theCell
we would invert the entire composition, while we should be really inverting them separately.Also fixes an issue where the
ItemSeparatorComponent
was not being inverted properly (noticeable if you would add text to it for example, since we'd never invert this).🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
develop
branch