Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong path in gh workflow for SampleApp #2643

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: wrong path in gh workflow for SampleApp #2643

merged 1 commit into from
Aug 29, 2024

Conversation

isekovanic
Copy link
Contributor

@isekovanic isekovanic commented Aug 29, 2024 •
edited
Loading

🎯 Goal

Pushing directly (and only) to the SampleApp path like so did not trigger a release, since the path was wrong (likely old structure).

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@isekovanic isekovanic merged commit e7cf0d5 into develop Aug 29, 2024
9 checks passed
@isekovanic isekovanic deleted the fix/gh-workflow-for-sample-app branch August 29, 2024 14:38
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.36.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverlaz oliverlaz Awaiting requested review from oliverlaz

@santhoshvai santhoshvai Awaiting requested review from santhoshvai

@khushal87 khushal87 Awaiting requested review from khushal87

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isekovanic @stream-ci-bot