fix: permissions issue on expo sample app on iOS and add docs for the same #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshvai
reviewed
Jun 10, 2024
| [ | ||
| "expo-image-picker", | ||
| { | ||
| "cameraPermission": "$(PRODUCT_NAME) would like to use your camera." |
There was a problem hiding this comment.
Suggested change
| "cameraPermission": "$(PRODUCT_NAME) would like to use your camera." | |
| "cameraPermission": "$(PRODUCT_NAME) would like to use your camera for sharing in a message" |
santhoshvai
reviewed
Jun 10, 2024
| [ | ||
| "expo-media-library", | ||
| { | ||
| "photosPermission": "$(PRODUCT_NAME) would like access to your photo gallery.", |
There was a problem hiding this comment.
Suggested change
| "photosPermission": "$(PRODUCT_NAME) would like access to your photo gallery.", | |
| "photosPermission": "$(PRODUCT_NAME) would like access to your photo gallery for sharing in a message.", |
santhoshvai
reviewed
Jun 10, 2024
| "expo-media-library", | ||
| { | ||
| "photosPermission": "$(PRODUCT_NAME) would like access to your photo gallery.", | ||
| "savePhotosPermission": "$(PRODUCT_NAME) would like to save photos to your photo gallery." |
There was a problem hiding this comment.
Suggested change
| "savePhotosPermission": "$(PRODUCT_NAME) would like to save photos to your photo gallery." | |
| "savePhotosPermission": "$(PRODUCT_NAME) would like to save photos to your photo gallery after downloading from a message" |
santhoshvai
reviewed
Jun 10, 2024
| [ | ||
| "expo-av", | ||
| { | ||
| "microphonePermission": "$(PRODUCT_NAME) would like to use your microphone." |
There was a problem hiding this comment.
Suggested change
| "microphonePermission": "$(PRODUCT_NAME) would like to use your microphone." | |
| "microphonePermission": "$(PRODUCT_NAME) would like to use your microphone for voice recording" |
santhoshvai
approved these changes
Jun 10, 2024
|
🎉 This PR is included in version 5.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch