Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Spanish translations #2292

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat: Add Spanish translations #2292

merged 1 commit into from
Nov 13, 2023

Conversation

manuelmhtr
Copy link
Contributor

🎯 Goal

Add translations file for Spanish.

🛠 Implementation details

  • Added Spanish translations
  • Added missing references for existing translations (Hebrew, Japanese, Korean)
  • Ordered translation references alphabetically by language id.

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

By configuring the app with the es language.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

khushal87
khushal87 requested changes Nov 9, 2023
View reviewed changes
package/src/i18n/es.json
"{{ replyCount }} Thread Replies": "{{ replyCount }} respuestas de hilo",
"{{ user }} is typing": "{{ user }} está escribiendo",
"🏙 Attachment...": "🏙 Adjunto..."
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just added a new translations for Maximum file size upload limit reached. Please upload a file below {{MAX_FILE_SIZE_TO_UPLOAD_IN_MB}} MB. and there is one coming for Select More Photos in https://github.com/GetStream/stream-chat-react-native/pull/2291/files.

Can you please add them? Thanks 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Done 👍

@manuelmhtr manuelmhtr requested a review from khushal87 November 9, 2023 16:22
@khushal87
Copy link
Member

Can you run yarn lint-fix and push the changes? Seems like linting checks are failing for the PR. @manuelmhtr

@manuelmhtr
Copy link
Contributor Author

Can you run yarn lint-fix and push the changes? Seems like linting checks are failing for the PR. @manuelmhtr

Sorry about that. It's fixed now.

@khushal87 khushal87 merged commit 899aaf2 into GetStream:develop Nov 13, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushal87 khushal87 khushal87 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelmhtr @khushal87 @stream-ci-bot