feat: update example apps to react native 0.67 [CRNS-538] #1199
Conversation
There was a problem hiding this comment.
Things aren't fine with this upgrade in SampleApp and TypeScript messaging app. There are lots of errors and warning which comes up while you try to do pod install. Also, the RCT_folly fails to install and it throws an error to update it. Can you please check?
| @@ -24,5 +24,6 @@ target 'TypeScriptMessaging' do | |||
| use_flipper!() | |||
| post_install do |installer| | |||
| react_native_post_install(installer) | |||
| __apply_Xcode_12_5_M1_post_install_workaround(installer) | |||
There was a problem hiding this comment.
Is this backwards compatible btw? I mean will it break for non M1
There was a problem hiding this comment.
Yes, it is backwards compatible and we must keep it. Or else the example apps won't run on M1.
This is a ruby script that runs over all the flipper pods and bumps their respective iOS target to 11.0.
This workaround should in theory be removed in react native once the underlying flipper issue is resolved. Pretty annoying tbh. The issue that @khushal87 faces are also due to some flipper workaround failing.
There is also a patch in 0.68 to resolve a folly issue facebook/react-native@60cef85, which could be related.
…as the official RN 0.67 template reference: facebook/react-native#32303
…ranch to test out testflight distribution
santhoshvai
force-pushed
the
santhosh/update-example-apps-0.67-crns-538
branch
from
39308ee
to
c0e4452
Compare
…posed to only perform a yarn build
|
🎉 This PR is included in version 4.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎯 Goal
NativeMessagingexample app🛠 Implementation details
Compared changes with https://react-native-community.github.io/upgrade-helper/ and implemented the same. Also updated some dependencies to stay compatible.
🎨 UI Changes
NA
🧪 Testing
Run the following command in both the apps and see if the app runs on both platforms.
☑️ Checklist
developbranch