fix: add pointerEvents to ReactionList #2196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Currently
ReactionList
has several Views that are take up basically the full screen width. These views have a height that is based on the reactionSize. Using the default reactionSize, these take up roughly half the size of theMessageContent
size if the message is a single line of text.This absolute overlay then blocks the
MessageContent
componentsTouchableOpacity
. Thus, the goal is to fix #2021 by makingReactionList
not block theTouchableOpacity
inMessageContent
. FYI I couldn't repo the hit box moving when adding a reaction, only the blocking of long press on both iOS and Android.🛠 Implementation details
Update the
View
andSvg
to havepointerEvents
that don't block the underlyingTouchableOpacity
fromMessageContnet
while maintaining theTouchOpacity
of theReactionList
functionality.🎨 UI Changes
iOS & Android
Screen.Recording.2023-07-24.at.16.37.20.mov
🧪 Testing
☑️ Checklist
develop
branch